ReadWriteLock upgradeToWrite fix for simultaneous upgrades.#134
Merged
accelerated merged 1 commit intobloomberg:masterfrom Nov 8, 2020
Merged
ReadWriteLock upgradeToWrite fix for simultaneous upgrades.#134accelerated merged 1 commit intobloomberg:masterfrom
accelerated merged 1 commit intobloomberg:masterfrom
Conversation
Signed-off-by: Alexander Damian <adamian@bloomberg.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
If
ReadWriteLock::upgradeToWrite()was called and there were more than one simultaneous upgrades occurring, the function would block indefinitely. This was caused by the underlying loop callingtryUpgradeToLock()not keeping upgrade state during iterations.This fix introduces a new overload
ReadWriteSpinlock::tryUpgradeToWrite(bool& pendingUpgrade)which should be used if calling this in a loop.Testing performed
The previous tests only covered calling
ReadWriteSpinlock::upgradeToWrite()which worked properly because it was not invoked inside a loop. TheReadWriteMutex::upgradeToWrite()calls it in a loop which was never actually tested. As a validation, running the new added test on the previous master branch blocks indefinitely which proves the fix is working correctly.Signed-off-by: Alexander Damian adamian@bloomberg.net