Quick apply redirects to facilitator applications#2613
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThis PR modifies Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Greptile SummaryThis PR fixes the redirect destination for the "Quick apply to facilitate again" sidebar panel: it previously linked to the first upcoming round's quick-apply URL (
Confidence Score: 5/5Safe to merge — a focused, well-tested one-component change with no side effects on other parts of the codebase. The change is minimal: one data-lookup expression and one href string replaced with a static route constant. Loading and empty-data states both continue to return null correctly. The tests cover the happy path and the guard conditions, and the new assertions match the updated behavior exactly. No files require special attention. Important Files Changed
Sequence DiagramsequenceDiagram
participant User
participant SidebarPanel as SidebarFacilitateAgainPanel
participant tRPC as tRPC (eligibleRounds)
participant FacilitatorApps as /facilitator-applications
User->>SidebarPanel: visits course page
SidebarPanel->>tRPC: useQuery (eligibleRounds)
tRPC-->>SidebarPanel: EligibleRoundsCourse[]
SidebarPanel->>SidebarPanel: "some(course => courseSlug matches && rounds.length > 0)"
alt no eligible round
SidebarPanel-->>User: render nothing
else has eligible round
SidebarPanel-->>User: render Quick apply to facilitate again link
User->>FacilitatorApps: click navigate to /facilitator-applications
end
Reviews (1): Last reviewed commit: "Update tests" | Re-trigger Greptile |
Description
When I built this, I assumed that the panel should redirect to the first upcoming round. This was incorrect. It should rather redirect to the facilitator-applications route.