Skip to content

Convert one exerciseResponses db.scan to pg lookup #2617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Will-Howard merged 1 commit into from
Jun 6, 2026
Merged

Convert one exerciseResponses db.scan to pg lookup #2617

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 10 additions & 6 deletions apps/website/src/server/routers/certificates.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,11 @@
import {
and,
courseRegistrationTable,
courseTable,
eq,
exerciseResponseTable,
exerciseTable,
inArray,
meetPersonTable,
roundTable,
type CourseRegistration,
Expand All @@ -25,12 +28,13 @@ async function areAllFoaiExercisesComplete(email: string): Promise<boolean> {

// Scope the response scan to FoAI exercises so we don't pull every response this user has ever
// submitted (across all courses) just to check FoAI completion.
const exerciseResponses = await db.scan(exerciseResponseTable, {
AND: [
{ email },
{ OR: allExercises.map((exercise) => ({ exerciseId: exercise.id })) },
],
});
const exerciseResponses = await db.pg
.select()
.from(exerciseResponseTable.pg)
.where(and(
eq(exerciseResponseTable.pg.email, email),
inArray(exerciseResponseTable.pg.exerciseId, allExercises.map((e) => e.id)),
));

const completedExerciseIds = new Set(exerciseResponses
.filter((resp) => resp.completedAt != null)
Expand Down
Loading