Skip to content

[fix] Revert VKE target to v1.33.0+3 to unblock infra CD#2619

Merged
joshestein merged 1 commit into
masterfrom
josh/2569-revert-vke-1.33
Jun 7, 2026
Merged

[fix] Revert VKE target to v1.33.0+3 to unblock infra CD#2619
joshestein merged 1 commit into
masterfrom
josh/2569-revert-vke-1.33

Conversation

@joshestein

Copy link
Copy Markdown
Collaborator

What

Reverts the VKE target in vke.ts from v1.35.5+1 back to v1.33.0+3.

Why

The upgrade merged in #2610 cannot apply — Vultr reports the cluster's version metadata as empty (""), which breaks upgrade-path validation everywhere:

  • Pulumi/provider → 422 "Validation error: invalid upgrade version"
  • raw API → same
  • Vultr dashboard "Start Upgrade" → silent no-op / reverts

So master currently has v1.35.5+1 while Pulumi state and the live cluster are still v1.33.0+3. Every infra deploy re-attempts the doomed upgrade and the cd job fails.

This reverts the code to match state + reality. pulumi preview should show no change (no-op), so infra CD goes green again instead of failing on every run.

Not a no-op forever

This is a temporary step-back, not abandoning the upgrade. Re-apply the v1.35.5+1 bump once Vultr repairs the cluster's version metadata.

Blocker tracked in #2618 (Vultr support). Prereq CNPG bump already merged (#2611). Prod is healthy on 1.33 throughout — no user impact.

🤖 Generated with Claude Code

The upgrade to v1.35.5+1 (#2610) cannot apply: Vultr reports the cluster's
version metadata as empty, which breaks upgrade-path validation across the
provider API, raw API, and dashboard. Pulumi state is still v1.33.0+3, so
this reverts the code to match, making infra deploys a no-op again instead
of re-attempting the doomed upgrade on every run.

Re-apply the 1.35.5+1 bump once Vultr repairs the metadata. Tracking: #2618.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@Will-Howard Will-Howard temporarily deployed to josh/2569-revert-vke-1.33 - bluedot-preview PR #2619 June 7, 2026 08:28 — with Render Destroyed
@Will-Howard Will-Howard temporarily deployed to josh/2569-revert-vke-1.33 - bluedot-storybook-preview PR #2619 June 7, 2026 08:28 — with Render Destroyed
@coderabbitai

coderabbitai Bot commented Jun 7, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Caution

Review failed

Pull request was closed or merged during review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: a59e8d26-eca3-4697-9a1f-52ef80de1fe5

📥 Commits

Reviewing files that changed from the base of the PR and between b6b3f98 and ce34f63.

📒 Files selected for processing (1)
  • apps/infra/src/vultr/vke.ts

📝 Walkthrough

Walkthrough

The Vultr Kubernetes cluster configuration in apps/infra/src/vultr/vke.ts was updated to pin the control-plane version to v1.33.0+3, downgrading from the previously pinned version v1.35.5+1. No changes to cluster configuration logic or exported provider wiring occurred.

Possibly related PRs

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Description check ❓ Inconclusive The description provides comprehensive context including what changed, why it was necessary, and important caveats about this being temporary. However, it does not follow the repository's required template structure with sections like 'Issue', 'Developer checklist', or 'Screenshot'. Restructure the description to match the repository template: add an 'Issue' section linking related issues (#2610, #2618, #2611), and include the 'Developer checklist' section even if items are not applicable.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: reverting the VKE Kubernetes version and the reason (unblocking infra CD). It is concise, specific, and clearly communicates the primary objective.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch josh/2569-revert-vke-1.33

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@greptile-apps

greptile-apps Bot commented Jun 7, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR reverts the VKE Kubernetes cluster version from v1.35.5+1 back to v1.33.0+3 in apps/infra/src/vultr/vke.ts. The upgrade introduced in #2610 is currently blocked by a Vultr bug where the cluster's version metadata is empty, causing every infra deploy to fail with a 422 validation error.

Confidence Score: 5/5

Safe to merge — this is a minimal, targeted revert that aligns code with the live cluster state and restores a working CD pipeline.

The change is a single-line revert bringing the declared Kubernetes version back in sync with the actual running cluster. There is no logic change, no new code path, and pulumi preview is expected to be a no-op. The root cause (Vultr cluster metadata bug) and the follow-up plan are clearly documented.

No files require special attention.

Important Files Changed

Filename Overview
apps/infra/src/vultr/vke.ts Single-line revert of VKE Kubernetes version from v1.35.5+1 back to v1.33.0+3 to unblock infra CD while a Vultr-side cluster metadata issue is resolved.

Sequence Diagram

sequenceDiagram
    participant GH as GitHub Actions (CD)
    participant Pulumi as Pulumi
    participant Vultr as Vultr API

    Note over GH,Vultr: Before this PR (broken state)
    GH->>Pulumi: pulumi up
    Pulumi->>Vultr: PATCH cluster version → v1.35.5+1
    Vultr-->>Pulumi: "422 Validation error (cluster version metadata = "")"
    Pulumi-->>GH: Deploy fails ❌

    Note over GH,Vultr: After this PR (reverted)
    GH->>Pulumi: pulumi up
    Pulumi->>Vultr: "desired version = v1.33.0+3 (matches live state)"
    Vultr-->>Pulumi: No change required ✅
    Pulumi-->>GH: Deploy succeeds ✅
Loading

Reviews (1): Last reviewed commit: "[fix] Revert VKE target to v1.33.0+3 to ..." | Re-trigger Greptile

@joshestein joshestein merged commit fa38cc0 into master Jun 7, 2026
6 of 7 checks passed
@joshestein joshestein deleted the josh/2569-revert-vke-1.33 branch June 7, 2026 08:31
joshestein added a commit that referenced this pull request Jun 8, 2026
Vultr reports this cluster's version as empty, which breaks upgrade
validation and re-poisons our Pulumi state on every read, so every infra
deploy fails with a 422 trying to "upgrade" the cluster (incl. the revert
in #2619). ignoreChanges:['version'] stops Pulumi attempting the rejected
upgrade, so other infra changes (e.g. #2627) can deploy.

Scoped to the version field only and removed once Vultr repairs the
metadata, after which we resume the 1.35.5+1 upgrade. Tracking: #2618.

Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants