[fix] Revert VKE target to v1.33.0+3 to unblock infra CD#2619
Conversation
The upgrade to v1.35.5+1 (#2610) cannot apply: Vultr reports the cluster's version metadata as empty, which breaks upgrade-path validation across the provider API, raw API, and dashboard. Pulumi state is still v1.33.0+3, so this reverts the code to match, making infra deploys a no-op again instead of re-attempting the doomed upgrade on every run. Re-apply the 1.35.5+1 bump once Vultr repairs the metadata. Tracking: #2618. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
Caution Review failedPull request was closed or merged during review No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe Vultr Kubernetes cluster configuration in Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Greptile SummaryThis PR reverts the VKE Kubernetes cluster version from
Confidence Score: 5/5Safe to merge — this is a minimal, targeted revert that aligns code with the live cluster state and restores a working CD pipeline. The change is a single-line revert bringing the declared Kubernetes version back in sync with the actual running cluster. There is no logic change, no new code path, and pulumi preview is expected to be a no-op. The root cause (Vultr cluster metadata bug) and the follow-up plan are clearly documented. No files require special attention. Important Files Changed
Sequence DiagramsequenceDiagram
participant GH as GitHub Actions (CD)
participant Pulumi as Pulumi
participant Vultr as Vultr API
Note over GH,Vultr: Before this PR (broken state)
GH->>Pulumi: pulumi up
Pulumi->>Vultr: PATCH cluster version → v1.35.5+1
Vultr-->>Pulumi: "422 Validation error (cluster version metadata = "")"
Pulumi-->>GH: Deploy fails ❌
Note over GH,Vultr: After this PR (reverted)
GH->>Pulumi: pulumi up
Pulumi->>Vultr: "desired version = v1.33.0+3 (matches live state)"
Vultr-->>Pulumi: No change required ✅
Pulumi-->>GH: Deploy succeeds ✅
Reviews (1): Last reviewed commit: "[fix] Revert VKE target to v1.33.0+3 to ..." | Re-trigger Greptile |
Vultr reports this cluster's version as empty, which breaks upgrade validation and re-poisons our Pulumi state on every read, so every infra deploy fails with a 422 trying to "upgrade" the cluster (incl. the revert in #2619). ignoreChanges:['version'] stops Pulumi attempting the rejected upgrade, so other infra changes (e.g. #2627) can deploy. Scoped to the version field only and removed once Vultr repairs the metadata, after which we resume the 1.35.5+1 upgrade. Tracking: #2618. Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
What
Reverts the VKE target in
vke.tsfromv1.35.5+1back tov1.33.0+3.Why
The upgrade merged in #2610 cannot apply — Vultr reports the cluster's
versionmetadata as empty (""), which breaks upgrade-path validation everywhere:422 "Validation error: invalid upgrade version"So master currently has
v1.35.5+1while Pulumi state and the live cluster are stillv1.33.0+3. Every infra deploy re-attempts the doomed upgrade and thecdjob fails.This reverts the code to match state + reality.
pulumi previewshould show no change (no-op), so infra CD goes green again instead of failing on every run.Not a no-op forever
This is a temporary step-back, not abandoning the upgrade. Re-apply the
v1.35.5+1bump once Vultr repairs the cluster's version metadata.Blocker tracked in #2618 (Vultr support). Prereq CNPG bump already merged (#2611). Prod is healthy on 1.33 throughout — no user impact.
🤖 Generated with Claude Code