[chore] db: drop all current deprecated columns#2626
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
📝 WalkthroughWalkthroughThis pull request removes deprecation metadata from five table definitions in the database schema. The Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Greptile SummaryThis PR removes all remaining
Confidence Score: 5/5Safe to merge; the schema-only change deliberately removes stale column definitions that are unreferenced by any active code path. All removed columns were in No files require special attention. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[PR merged: deprecatedColumns removed from schema.ts] --> B[pg-sync-service starts / schema sync triggered]
B --> C[runDrizzlePush builds pgTables map]
C --> D{pgWithDeprecatedColumns set?}
D -- Previously YES --> E[deprecated cols included in expectedColumns]
D -- Now NO after this PR --> F[only active cols in expectedColumns]
F --> G[cleanupRemovedColumns compares DB vs schema]
G --> H[Finds image/path/description/avgRating/etc in DB but not schema]
H --> I[Issues ALTER TABLE ... DROP COLUMN for each stale column]
I --> J[pushSchemaWithTimeout runs — no extra diff]
J --> K[Schema fully in sync with new Postgres instance]
Reviews (1): Last reviewed commit: "[chore] db: drop all remaining deprecate..." | Re-trigger Greptile |
Description
This helps with #2624. There are some stale values in the current postgres db from before these columns were deprecated, which creates a diff between the current and new postgres instance. Dropping these columns will remove this difference, which makes it easier to verify that the contents of the two databases are the same.
Issue
#2624
Developer checklist