Skip to content

Remove footer from learning ux. Fix sidebar.#956

Merged
tarinrickett merged 2 commits into
masterfrom
tarin/chunky-fix
May 22, 2025
Merged

Remove footer from learning ux. Fix sidebar.#956
tarinrickett merged 2 commits into
masterfrom
tarin/chunky-fix

Conversation

@tarinrickett

@tarinrickett tarinrickett commented May 22, 2025

Copy link
Copy Markdown
Contributor

Description

A more focused learner experience

Developer checklist

Screenshot

Screen.Recording.2025-05-22.at.2.00.24.PM.mov
Screen.Recording.2025-05-22.at.1.59.38.PM.mov
Screen.Recording.2025-05-22.at.2.06.43.PM.mov

Summary by CodeRabbit

  • New Features
    • The footer is now hidden on individual course unit pages for a cleaner viewing experience.
  • Style
    • Improved the layout and sidebar behavior in course units, making the sidebar fixed and scrollable on desktop for easier navigation. The main content area is now properly offset to accommodate the sidebar.

@coderabbitai

coderabbitai Bot commented May 22, 2025

Copy link
Copy Markdown
Contributor

Walkthrough

The changes update the layout and styling of the unit page, making the sidebar fixed and scrollable on desktop, and adjusting the main content margin accordingly. Additionally, the global app logic now conditionally hides the footer if a page component sets a hideFooter property, which is applied to the course unit page.

Changes

File(s) Change Summary
apps/website/src/components/courses/UnitLayout.tsx Updated layout: sidebar is fixed and scrollable on desktop, main content margin adjusted, border removed from main section.
apps/website/src/pages/_app.tsx Added logic to conditionally hide the footer based on a hideFooter property on the rendered component.
apps/website/src/pages/courses/[courseSlug]/[unitId].tsx Added static property hideFooter = true to the page component to suppress the footer on this page.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant NextApp
    participant PageComponent
    participant Footer

    User->>NextApp: Navigates to a page
    NextApp->>PageComponent: Render page
    PageComponent-->>NextApp: Returns component (may have hideFooter)
    alt PageComponent.hideFooter is true
        NextApp--x Footer: Do not render Footer
    else
        NextApp->>Footer: Render Footer
    end
Loading

Suggested labels

size:S

Poem

A sidebar now fixed, content slides right,
The footer may vanish—oh, what a sight!
With scrollable menus and margins anew,
The unit page shines with a sleeker view.
Hop, hop, says the rabbit, in code we delight!
🐇✨

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

npm warn config production Use --omit=dev instead.
npm error Exit handler never called!
npm error This is an error with npm itself. Please report this error at:
npm error https://github.com/npm/cli/issues
npm error A complete log of this run can be found in: /.npm/_logs/2025-05-22T21_09_38_066Z-debug-0.log

Note

⚡️ AI Code Reviews for VS Code, Cursor, Windsurf

CodeRabbit now has a plugin for VS Code, Cursor and Windsurf. This brings AI code reviews directly in the code editor. Each commit is reviewed immediately, finding bugs before the PR is raised. Seamless context handoff to your AI code agent ensures that you can easily incorporate review feedback.
Learn more here.


Note

⚡️ Faster reviews with caching

CodeRabbit now supports caching for code and dependencies, helping speed up reviews. This means quicker feedback, reduced wait times, and a smoother review experience overall. Cached data is encrypted and stored securely. This feature will be automatically enabled for all accounts on May 30th. To opt out, configure Review - Disable Cache at either the organization or repository level. If you prefer to disable all data retention across your organization, simply turn off the Data Retention setting under your Organization Settings.
Enjoy the performance boost—your workflow just got faster.


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between bc5bf23 and 7f47a8f.

⛔ Files ignored due to path filters (1)
  • apps/website/src/components/courses/__snapshots__/UnitLayout.test.tsx.snap is excluded by !**/*.snap
📒 Files selected for processing (3)
  • apps/website/src/components/courses/UnitLayout.tsx (1 hunks)
  • apps/website/src/pages/_app.tsx (2 hunks)
  • apps/website/src/pages/courses/[courseSlug]/[unitId].tsx (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: ci
🔇 Additional comments (6)
apps/website/src/pages/courses/[courseSlug]/[unitId].tsx (1)

54-55: Looks good! This correctly hides the footer on course unit pages.

This addition of the static property hideFooter = true to the CourseUnitPage component is a clean approach to control footer visibility without modifying the component's internal logic.

apps/website/src/pages/_app.tsx (2)

15-15: Good implementation of the footer visibility mechanism.

Using 'hideFooter' in Component is an elegant way to check for the static property's existence.


53-53: Effective conditional rendering of the footer.

This change properly implements the selective footer hiding based on the component's static property.

apps/website/src/components/courses/UnitLayout.tsx (3)

180-180: Good removal of border for cleaner UI.

Removing the border from the main unit section creates a more streamlined appearance.


184-184: Excellent sidebar improvements for desktop view.

The fixed, scrollable sidebar with a calculated maximum height improves usability on desktop while ensuring it fits properly within the viewport.


191-191: Good adjustment of content margin to accommodate fixed sidebar.

The margin-left of [320px] properly offsets the main content to prevent overlap with the fixed sidebar.

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@greptile-apps greptile-apps Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This PR enhances the learning experience by streamlining the UI, removing distractions, and improving navigation in course units.

  • Added hideFooter property in apps/website/src/pages/courses/[courseSlug]/[unitId].tsx to conditionally hide footer on course pages
  • Modified sidebar in apps/website/src/components/courses/UnitLayout.tsx to be fixed position with calculated max height for better scrolling
  • Removed border from main section and adjusted content area margins in apps/website/src/components/courses/UnitLayout.tsx for cleaner layout

3 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

@tarinrickett tarinrickett merged commit 4f09391 into master May 22, 2025
4 checks passed
@tarinrickett tarinrickett deleted the tarin/chunky-fix branch May 22, 2025 21:13
@coderabbitai coderabbitai Bot mentioned this pull request Oct 7, 2025
3 tasks
@coderabbitai coderabbitai Bot mentioned this pull request Feb 23, 2026
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant