Skip to content

Conversation

@ja-ford
Copy link
Contributor

@ja-ford ja-ford commented Sep 5, 2025

Fixes bluenviron/mediamtx#4848

The encoding name used to identify and mark KLV packets appropriately was typo'd in a few places as "smtpe" ("tpe" vs "pte"). This was causing downstream consumers (including ffmpeg and gstreamer) to not properly identify KLV data streams, and may have caused issues with mediamtx itself identifying KLV data streams (unconfirmed). This typo was introduced in #808

This PR fixes the typo and adjusts casing to stay consistent with other encoding-name mappings in this library.

Testing

We tested this fix locally by serving an MPEGTS file with KLV data via an RTSP stream directly in mediamtx and receiving the stream in gstreamer:

gst-launch-1.0 rtspsrc location="rtsp://127.0.0.1:8554/stream" ! rtpklvdepay ! fakesink

The rtpklvdepay element successfully identifies KLV packets from the stream after this fix.

@codecov
Copy link

codecov bot commented Sep 5, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.92%. Comparing base (6add580) to head (85c6afd).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #877      +/-   ##
==========================================
- Coverage   80.94%   80.92%   -0.03%     
==========================================
  Files         128      128              
  Lines       14323    14323              
==========================================
- Hits        11594    11591       -3     
- Misses       2204     2206       +2     
- Partials      525      526       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@aler9
Copy link
Member

aler9 commented Sep 5, 2025

merged, thank you very much!

@aler9 aler9 merged commit a8513af into bluenviron:main Sep 5, 2025
10 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

mediamtx RTSP SDP advertises KLV as smtpe336m and reuses PT=96 → players don’t detect KLV (shows as Data: none)

2 participants