Fix typo when identifying KLV packets as SMPTE336M-encoded #877
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes bluenviron/mediamtx#4848
The encoding name used to identify and mark KLV packets appropriately was typo'd in a few places as "smtpe" ("tpe" vs "pte"). This was causing downstream consumers (including ffmpeg and gstreamer) to not properly identify KLV data streams, and may have caused issues with mediamtx itself identifying KLV data streams (unconfirmed). This typo was introduced in #808
This PR fixes the typo and adjusts casing to stay consistent with other encoding-name mappings in this library.
Testing
We tested this fix locally by serving an MPEGTS file with KLV data via an RTSP stream directly in mediamtx and receiving the stream in gstreamer:
The
rtpklvdepayelement successfully identifies KLV packets from the stream after this fix.