Skip to content

Conversation

@aler9
Copy link
Member

@aler9 aler9 commented Feb 18, 2025

No description provided.

@codecov
Copy link

codecov bot commented Feb 18, 2025

Codecov Report

Attention: Patch coverage is 70.32967% with 27 lines in your changes missing coverage. Please review.

Project coverage is 56.66%. Comparing base (7ade289) to head (db46006).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
internal/servers/rtsp/session.go 61.90% 6 Missing and 2 partials ⚠️
internal/servers/rtsp/conn.go 70.00% 4 Missing and 2 partials ⚠️
internal/auth/manager.go 87.50% 2 Missing ⚠️
internal/servers/rtmp/conn.go 0.00% 2 Missing ⚠️
internal/servers/srt/conn.go 0.00% 2 Missing ⚠️
internal/api/api.go 0.00% 1 Missing ⚠️
internal/auth/request.go 0.00% 1 Missing ⚠️
internal/metrics/metrics.go 0.00% 1 Missing ⚠️
internal/playback/server.go 0.00% 1 Missing ⚠️
internal/pprof/pprof.go 0.00% 1 Missing ⚠️
... and 2 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4267      +/-   ##
==========================================
- Coverage   56.68%   56.66%   -0.02%     
==========================================
  Files         203      203              
  Lines       20689    20646      -43     
==========================================
- Hits        11727    11699      -28     
+ Misses       8094     8081      -13     
+ Partials      868      866       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aler9 aler9 force-pushed the feature/rtsp-verify branch 3 times, most recently from 6d8c395 to 2f08bef Compare February 18, 2025 16:33
@aler9 aler9 force-pushed the feature/rtsp-verify branch from 2f08bef to db46006 Compare February 18, 2025 16:48
@aler9 aler9 merged commit 386be42 into main Feb 18, 2025
8 checks passed
@aler9 aler9 deleted the feature/rtsp-verify branch February 18, 2025 16:54
@github-actions
Copy link
Contributor

This issue is mentioned in release v1.12.0 🚀
Check out the entire changelog by clicking here

1 similar comment
@github-actions
Copy link
Contributor

This issue is mentioned in release v1.12.0 🚀
Check out the entire changelog by clicking here

aler9 added a commit that referenced this pull request May 26, 2025
since #4267 it was impossible to perform authentication when protocol
is RTSP and credentials are hashed
aler9 added a commit that referenced this pull request May 26, 2025
since #4267 it was impossible to perform authentication when protocol
is RTSP and credentials are hashed
aler9 added a commit that referenced this pull request May 26, 2025
since #4267 it was impossible to perform authentication when protocol
is RTSP and credentials are hashed.
@github-actions
Copy link
Contributor

This issue is mentioned in release v1.12.3 🚀
Check out the entire changelog by clicking here

@github-actions github-actions bot locked and limited conversation to collaborators Aug 24, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants