Skip to content

Conversation

@aler9
Copy link
Member

@aler9 aler9 commented Oct 11, 2025

When the absolute timestamp of incoming frames was not available, it
was filled with the current timestamp, which is influenced by latency
over time.

This mechanism is replaced by an algorithm that detects when latency is
the lowest, stores the current timestamp and uses it as reference
throughout the rest of the stream.

@codecov
Copy link

codecov bot commented Oct 11, 2025

Codecov Report

❌ Patch coverage is 49.71098% with 87 lines in your changes missing coverage. Please review.
✅ Project coverage is 54.66%. Comparing base (f5f0356) to head (aa1ea76).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
internal/protocols/hls/to_stream.go 33.33% 37 Missing and 1 partial ⚠️
internal/protocols/webrtc/to_stream.go 17.85% 21 Missing and 2 partials ⚠️
internal/protocols/mpegts/to_stream.go 0.00% 10 Missing ⚠️
internal/protocols/rtmp/to_stream.go 9.09% 10 Missing ⚠️
internal/stream/stream_format.go 57.14% 2 Missing and 1 partial ⚠️
internal/protocols/webrtc/incoming_track.go 50.00% 2 Missing ⚠️
internal/protocols/rtsp/to_stream.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5078      +/-   ##
==========================================
+ Coverage   54.57%   54.66%   +0.09%     
==========================================
  Files         180      181       +1     
  Lines       18620    18653      +33     
==========================================
+ Hits        10161    10197      +36     
+ Misses       7742     7738       -4     
- Partials      717      718       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@aler9 aler9 force-pushed the feature/ntp branch 2 times, most recently from b15c3f6 to 9d4f4b2 Compare October 11, 2025 10:19
When the absolute timestamp of incoming frames was not available, it
was filled with the current timestamp, which is influenced by latency
over time.

This mechanism is replaced by an algorithm that detects when latency is
the lowest, stores the current timestamp and uses it as reference
throughout the rest of the stream.
@aler9 aler9 merged commit 0cdae40 into main Oct 12, 2025
8 of 9 checks passed
@aler9 aler9 deleted the feature/ntp branch October 12, 2025 09:02
@github-actions
Copy link
Contributor

This issue is mentioned in release v1.15.2 🚀
Check out the entire changelog by clicking here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants