recorder: prevent FMP4 durations from overflowing (#4711) #5126
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5126 +/- ##
==========================================
+ Coverage 54.71% 55.57% +0.86%
==========================================
Files 183 183
Lines 18716 15453 -3263
==========================================
- Hits 10240 8588 -1652
+ Misses 7756 6146 -1610
+ Partials 720 719 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
aler9
added a commit
to bluenviron/gohlslib
that referenced
this pull request
Oct 23, 2025
aler9
added a commit
to bluenviron/gohlslib
that referenced
this pull request
Oct 23, 2025
The timestamp difference between two samples was put inside an unsigned integer, and, when negative, caused an overflow.
aler9
changed the title
aler9
added a commit
to bluenviron/gohlslib
that referenced
this pull request
Oct 26, 2025
Contributor
|
This issue is mentioned in release v1.15.4 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4711
The timestamp difference between two samples was put inside an unsigned integer, and, when negative, caused an overflow.