Skip to content

Support no_std in nodrop #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 6, 2016
Merged

Support no_std in nodrop #25

merged 1 commit into from
Feb 6, 2016

Conversation

gereeter
Copy link
Contributor

@gereeter gereeter commented Feb 6, 2016

See #20.

@gereeter
Copy link
Contributor Author

gereeter commented Feb 6, 2016

Ah - you are testing against Rust 1.2, which doesn't have stable core. Should I put this behind a cargo feature?

@bluss
Copy link
Owner

bluss commented Feb 6, 2016

Right, we need a solution for that. Nice crate that doesn't need anything from std.

I want to use a std feature and have it enabled by default. There was some discussion about what the community's standard solution for this was going to be, but I think that's fine.

Moving the baseline from Rust 1.2 is fine, but not all the way up to Rust 1.6 yet I think?

Discussion in rust-lang/libc#146

@bluss
Copy link
Owner

bluss commented Feb 6, 2016

Heck, I think Rust 1.6 is fine, we can do a bump to version 0.2. This crate doesn't take any harm from 0.1 -> 0.2 bumping does it, it doesn't share types really with other crates, so the implications should be minimal.

@bluss
Copy link
Owner

bluss commented Feb 6, 2016

To edit that thought, that makes it complicated for ArrayVec.. where a major version bump has larger ramifications..

@bluss
Copy link
Owner

bluss commented Feb 6, 2016

Thanks. I'll merge this & fix it up.

bluss added a commit that referenced this pull request Feb 6, 2016
Support no_std in nodrop
@bluss bluss merged commit 62d2cef into bluss:master Feb 6, 2016
@gereeter gereeter deleted the no-std branch February 6, 2016 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants