Update scala 2.13.0-M5 to 2.13.0-RC2 #17
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SethTisue
reviewed
Apr 24, 2019
| @@ -34,7 +34,7 @@ object Implicits { | |||
| if (file.exists) | |||
| Success(true) | |||
| else | |||
| Failure(new FileDoesNotExistException(s""""$file" does not exist.""")) | |||
| Failure(new FileDoesNotExistException(s""""${file.toString}" does not exist.""")) | |||
There was a problem hiding this comment.
curious about this and the other similar diffs, why is this necessary/desirable?
There was a problem hiding this comment.
The [wartremover:StringPlusAny] Implicit conversion to string is disabled-wart triggers on scala 2.13.0-RC1, which maybe it shouldn't? On scala 2.12.8 it does not.
There was a problem hiding this comment.
ah. hmmm....
I think I personally wouldn't expect or want the wart to trigger inside a string interpolator, but that's just a hunch, not sure what the wart's author's intentions might have been
There was a problem hiding this comment.
I filed an issue here: wartremover/wartremover#447
Philippus
changed the title
Philippus
force-pushed
the
update/scala-2.13.0-RC1
branch
from
6a4b296 to
7f34848
Compare
|
Merged. I'll release an update soon—this weekend, if not before. (I've been swamped.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.