Skip to content

docs: 'no-commit' removed for forge from 2023 #644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 15, 2025
Merged

docs: 'no-commit' removed for forge from 2023 #644

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0425ea2
fix vm.mockCall
MatusKysel Sep 10, 2025
8d0d04d
README: 'no-commit' removed for forge from 2023
allformless Sep 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion test/Governor.t.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ contract GovernorTest is Deployer {
receive() external payable { }

function setUp() public {
vm.mockCall(address(0x66), "", hex"01");
vm.mockCall(address(0x66), bytes(""), hex"01");
}

function testDelegateVote() public {
Expand Down
4 changes: 2 additions & 2 deletions test/SlashIndicator.t.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ contract SlashIndicatorTest is Deployer {

// set gas price to zero to send system slash tx
vm.txGasPrice(0);
vm.mockCall(address(0x66), "", hex"01");
vm.mockCall(address(0x66), bytes(""), hex"01");
}

function testGov() public {
Expand Down Expand Up @@ -284,7 +284,7 @@ contract SlashIndicatorTest is Deployer {

uint256 mockEvidenceHeight = block.number - 1;
bytes memory mockOutput = bytes.concat(abi.encodePacked(mockValidator), abi.encodePacked(mockEvidenceHeight));
vm.mockCall(address(0x68), "", mockOutput);
vm.mockCall(address(0x68), bytes(""), mockOutput);
vm.mockCall(
address(stakeHub), abi.encodeCall(stakeHub.consensusToOperator, (mockValidator)), abi.encode(mockValidator)
);
Expand Down
2 changes: 1 addition & 1 deletion test/StakeHub.t.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ contract StakeHubTest is Deployer {
receive() external payable { }

function setUp() public {
vm.mockCall(address(0x66), "", hex"01");
vm.mockCall(address(0x66), bytes(""), hex"01");
}

function testCreateValidator() public {
Expand Down
4 changes: 2 additions & 2 deletions test/TokenRecoverPortal.t.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ contract TokenRecoverPortalTest is Deployer {
bytes merkleRoot = hex"59bb94f7047904a8fdaec42e4785295167f7fd63742b309afeb84bd71f8e6554";

function setUp() public {
vm.mockCall(address(0x69), "", mockTokenOwner);
vm.mockCall(address(0x69), bytes(""), mockTokenOwner);
// slot id for `merkleRootAlreadyInit`
bytes32 slot = bytes32(uint256(105));

Expand Down Expand Up @@ -226,7 +226,7 @@ contract TokenRecoverPortalTest is Deployer {
) = recoverParams();

vm.expectRevert();
vm.mockCall(address(0x69), "", hex"1111100f29effb427fb76a185b4ac73ea09a534b");
vm.mockCall(address(0x69), bytes(""), hex"1111100f29effb427fb76a185b4ac73ea09a534b");
ownerPubKey = hex"11111111cd7da2e96d39bcbd0390bfed461a86382f7a2923436ff16c65cabc7720";
// failed to recover the token
tokenRecoverPortal.recover(tokenSymbol, amount, ownerPubKey, ownerSignature, approvalSignature, merkleProof);
Expand Down
2 changes: 1 addition & 1 deletion test/ValidatorSet.t.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ contract ValidatorSetTest is Deployer {

// set gas price to zero to send system slash tx
vm.txGasPrice(0);
vm.mockCall(address(0x66), "", hex"01");
vm.mockCall(address(0x66), bytes(""), hex"01");
}

function testDeposit(uint256 amount) public {
Expand Down
Loading