Added PipEnv ".venv" to directories ignored and log filename when UnicodeDecodeError exception is caught. #185

valveca-ai · 2020-01-03T17:21:13Z

Pipreqs was failing with UnicodeDecodeError without indicating the filename that caused the error. The root case was PipEnv's ".venv" folder was being processed.

This PR adds ".venv" to directories to ignore, and moves the code that reads the file to process inside the try/catch block in order to log the filename that caused the issue.

The file that caused the failure was:

/Users/XXXXX/dev/XXXXX/.venv/lib/python3.7/site-packages/IPython/core/tests/nonascii.py

and the terminal output was:

$ pipreqs --debug 
Traceback (most recent call last):
  File "/Users/XXXXX/dev/XXXXX/.venv/bin/pipreqs", line 10, in <module>
    sys.exit(main())
  File "/Users/XXXXX/dev/XXXXX/.venv/lib/python3.7/site-packages/pipreqs/pipreqs.py", line 470, in main
    init(args)
  File "/Users/XXXXX/dev/XXXXX/.venv/lib/python3.7/site-packages/pipreqs/pipreqs.py", line 409, in init
    follow_links=follow_links)
  File "/Users/XXXXX/dev/XXXXX/.venv/lib/python3.7/site-packages/pipreqs/pipreqs.py", line 122, in get_all_imports
    contents = f.read()
  File "/Users/XXXXX/dev/XXXXX/.venv/bin/../lib/python3.7/codecs.py", line 322, in decode
    (result, consumed) = self._buffer_decode(data, self.errors, final)
UnicodeDecodeError: 'utf-8' codec can't decode byte 0xb1 in position 81: invalid start bytedatetime64

Although pipreqs would have worked properly adding "--ignore .venv" flag, the user would not easily know where it was failing.

My environment is:

MacOS 10.15.2
Python 3.7.3
pipreqs==0.4.10

…eDecodeError exception is caught.

coveralls · 2020-01-03T17:24:02Z