Implement new spec changes for AsyncGenerator
#3950
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jedel1043
force-pushed
the
new-async-generator
branch
from
c98c6a7 to
c06b882
Compare
jedel1043
force-pushed
the
new-async-generator
branch
from
c06b882 to
699a842
Compare
Test262 conformance changes
Broken tests (2): |
Member
Author
|
Checked and the regressions are bugs in the test suite caused by recent changes to the |
nekevss
approved these changes
Aug 16, 2024
Member
nekevss
left a comment
nekevss
left a comment
There was a problem hiding this comment.
Looks good to me. Couple nits but they're non-blocking.
HalidOdat
approved these changes
Aug 17, 2024
Member
HalidOdat
left a comment
HalidOdat
left a comment
There was a problem hiding this comment.
Nice work! Looks good to me! :)
jedel1043
added a commit
that referenced
this pull request
Sep 11, 2024
* Implement new spec changes for `AsyncGenerator` * Add panic docs
raskad
pushed a commit
that referenced
this pull request
Sep 11, 2024
* Implement new spec changes for `AsyncGenerator` (#3950) * Implement new spec changes for `AsyncGenerator` * Add panic docs * Add spec edition 15 to the tester (#3957) * Allow dead code for code that is newly detected as unused (#3984) * Allow dead code for code that is newly detected as unused * Fix compile errors with nightly rust * Add missing SAFETY section * Increase safety of `FutexWaiters` --------- Co-authored-by: Theo Paris <theo@tinted.dev> Co-authored-by: José Julián Espina <julian.espina@canonical.com> * Enable CI for release branches (#3987) * Allow warnings when running CI on release branches (#3990) * Bump crates version --------- Co-authored-by: Hans Larsen <hans@larsen.online> Co-authored-by: Theo Paris <theo@tinted.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Essentially the same as #3879 but supported by the latest specification.