Skip to content

updated pinner to update pins in case they change per pinner instance #153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bogdanfinn merged 1 commit into from
Jan 21, 2025
Merged

updated pinner to update pins in case they change per pinner instance #153

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions pinner.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ package tls_client
import (
"errors"
"fmt"
"reflect"
"strings"

http "github.com/bogdanfinn/fhttp"
Expand Down Expand Up @@ -53,8 +54,8 @@ func (cp *certificatePinner) init() error {

pinnedHost := certificatePinStorage.Lookup(host)

if pinnedHost != nil {
// another pinner instance already initialized the host. we do not need to pin again
if pinnedHost != nil && reflect.DeepEqual(pinnedHost.Sha256Pins, pinsByHost) {
// another pinner instance with the same Pins already initialized the host. we do not need to pin again
continue
}

Expand Down