fix unmarshalling of /products endpoint via custom type#118
Merged
Conversation
Author
|
@andig would you mind reviewing? |
andig
reviewed
Nov 25, 2023
Author
|
I am completely puzzled by the issue reported by golangci-lint. |
Collaborator
|
Just dont use dot imports? |
Author
That's of course one way to solve this. However the dot import style is also used by the other tests in the project, and mores this is also how the authors of convey show this in their docs. At the end of the day, the code style part for sure is arguable. What's more odd though is that the linter claims an unused import, although that's incorrect. But I will cut my losses here, and just adjust accordingly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #117