Fix XXE vulnerability in XML parsing function#1458
Merged
Conversation
Owner
|
@yannaingtun Many thanks for contributing! It is merged now. |
Contributor
Author
|
Hello @bonigarcia! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
This PR fixes an XXE vulnerability (CWE-611) in the loadXML() function, similar to the one fixed in the biojava project (commit 1c94548).
The fix adds factory.setFeature(XMLConstants.FEATURE_SECURE_PROCESSING, true) and additional hardening to prevent attackers from exploiting XML parsing to access local files or perform SSRF attacks.
References
OWASP XXE Prevention: https://cheatsheetseries.owasp.org/cheatsheets/XML_External_Entity_Prevention_Cheat_Sheet.html
Original fix: biojava/biojava@1c94548
Java XML Security Guide: https://docs.oracle.com/en/java/javase/11/security/java-api-xml-processing-jaxp-security-guide.html