#8 Don't use autowired or constructor injection with FactoryBeans #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #12 +/- ##
=============================================
+ Coverage 67.05% 67.07% +0.01%
- Complexity 663 664 +1
=============================================
Files 84 84
Lines 2289 2290 +1
Branches 402 402
=============================================
+ Hits 1535 1536 +1
Misses 570 570
Partials 184 184
Continue to review full report at Codecov.
|
boostchicken
added a commit
that referenced
this pull request
Feb 25, 2020
* Read Consistency Setting * #8 Custom Mapper Spec * #8 Custom Mapper CDI fix * Fix symlink to CONTRIBUTING.md (#13) * #8 Don't use autowired or constructor injection with FactoryBeans (#12) * [maven-release-plugin] prepare release v5.2.2 * [maven-release-plugin] prepare for next development iteration Co-authored-by: Christian Frommeyer <[email protected]>
boostchicken
added a commit
that referenced
this pull request
Feb 25, 2020
* Read Consistency Setting * #8 Custom Mapper Spec * #8 Custom Mapper CDI fix * Fix symlink to CONTRIBUTING.md (#13) * #8 Don't use autowired or constructor injection with FactoryBeans (#12) * [maven-release-plugin] prepare release v5.2.2 * [maven-release-plugin] prepare for next development iteration * 5.2.2 docs fix * Hibernate Validator CVE fix GHSA-m8p2-495h-ccmh * Documentation updates * Create FUNDING.yml * Fixed a Type (#17) Co-authored-by: thedevluffy <[email protected]> * Documentation updates * 5.2.3 prep * [maven-release-plugin] prepare release v5.2.3 * [maven-release-plugin] prepare for next development iteration Co-authored-by: Christian Frommeyer <[email protected]> Co-authored-by: thedevluffy <[email protected]>
boostchicken
added a commit
that referenced
this pull request
Jun 17, 2020
* v5.2.3 (#18) * Read Consistency Setting * #8 Custom Mapper Spec * #8 Custom Mapper CDI fix * Fix symlink to CONTRIBUTING.md (#13) * #8 Don't use autowired or constructor injection with FactoryBeans (#12) * [maven-release-plugin] prepare release v5.2.2 * [maven-release-plugin] prepare for next development iteration * 5.2.2 docs fix * Hibernate Validator CVE fix GHSA-m8p2-495h-ccmh * Documentation updates * Create FUNDING.yml * Fixed a Type (#17) Co-authored-by: thedevluffy <[email protected]> * Documentation updates * 5.2.3 prep * [maven-release-plugin] prepare release v5.2.3 * [maven-release-plugin] prepare for next development iteration Co-authored-by: Christian Frommeyer <[email protected]> Co-authored-by: thedevluffy <[email protected]> * ✨ Allow CONTAINS and NOT_CONTAINS is repositories * 🎨 cleanup * 🔧 check for collection * 🔧 check for collection * ✏️ cleanup * 🎨 cleanup imports * Remove funding changes Co-authored-by: John D <[email protected]> Co-authored-by: Christian Frommeyer <[email protected]> Co-authored-by: thedevluffy <[email protected]> Co-authored-by: John Dorman <[email protected]> Co-authored-by: Hannes Angst <[email protected]>
boostchicken
added a commit
that referenced
this pull request
Jun 17, 2020
* Update FUNDING.yml * Introduce string set handling (#34) * v5.2.3 (#18) * Read Consistency Setting * #8 Custom Mapper Spec * #8 Custom Mapper CDI fix * Fix symlink to CONTRIBUTING.md (#13) * #8 Don't use autowired or constructor injection with FactoryBeans (#12) * [maven-release-plugin] prepare release v5.2.2 * [maven-release-plugin] prepare for next development iteration * 5.2.2 docs fix * Hibernate Validator CVE fix GHSA-m8p2-495h-ccmh * Documentation updates * Create FUNDING.yml * Fixed a Type (#17) Co-authored-by: thedevluffy <[email protected]> * Documentation updates * 5.2.3 prep * [maven-release-plugin] prepare release v5.2.3 * [maven-release-plugin] prepare for next development iteration Co-authored-by: Christian Frommeyer <[email protected]> Co-authored-by: thedevluffy <[email protected]> * ✨ Allow CONTAINS and NOT_CONTAINS is repositories * 🎨 cleanup * 🔧 check for collection * 🔧 check for collection * ✏️ cleanup * 🎨 cleanup imports * Remove funding changes Co-authored-by: John D <[email protected]> Co-authored-by: Christian Frommeyer <[email protected]> Co-authored-by: thedevluffy <[email protected]> Co-authored-by: John Dorman <[email protected]> Co-authored-by: Hannes Angst <[email protected]> * Updating changelog for #33 * Updating for release * [maven-release-plugin] prepare release v5.2.5 * [maven-release-plugin] prepare for next development iteration Co-authored-by: Hannes Angst <[email protected]> Co-authored-by: Christian Frommeyer <[email protected]> Co-authored-by: thedevluffy <[email protected]> Co-authored-by: Hannes Angst <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in line with the JavaDoc on
org.springframework.beans.factory.FactoryBean<T>use theBeanFactoryinstead of constructor autowired beans by implementingBeanFactoryAware.