Skip to content

Conversation

@alandefreitas
Copy link
Member

fix #947

@cppalliance-bot
Copy link

cppalliance-bot commented Nov 12, 2025

An automated preview of the documentation is available at https://952.url.prtest2.cppalliance.org/index.html

If more commits are pushed to the pull request, the docs will rebuild at the same URL.

2025-11-12 22:39:34 UTC

@vinniefalco
Copy link
Member

you might have pulled the trigger a little too quickly on this. look at how beast2 is using percent-decoding:

https://github.com/cppalliance/beast2/blob/daf37da49b4fdf3fcc66d4d6e920205717c86bd2/src/server/detail/any_router.cpp#L42

(I plan on refactoring to StringToken to re-use strings)

@alandefreitas
Copy link
Member Author

alandefreitas commented Nov 12, 2025

I plan on refactoring to StringToken to re-use strings

Don't we already have a string token for that?

https://952.url.prtest2.cppalliance.org/url/reference/boost/urls/string_token/assign_to.html

@cppalliance-bot
Copy link

GCOVR code coverage report https://952.url.prtest2.cppalliance.org/gcovr/index.html
LCOV code coverage report https://952.url.prtest2.cppalliance.org/genhtml/index.html
Coverage Diff https://952.url.prtest2.cppalliance.org/gcovr/coverage_diff.txt

Build time: 2025-11-12 22:45:52 UTC

@cppalliance-bot
Copy link

GCOVR code coverage report https://952.url.prtest2.cppalliance.org/gcovr/index.html
LCOV code coverage report https://952.url.prtest2.cppalliance.org/genhtml/index.html
Coverage Diff https://952.url.prtest2.cppalliance.org/gcovr/coverage_diff.txt

Build time: 2025-11-12 22:57:15 UTC

@codecov
Copy link

codecov bot commented Nov 12, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.21%. Comparing base (bbe9700) to head (24937d3).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #952   +/-   ##
========================================
  Coverage    99.21%   99.21%           
========================================
  Files          159      160    +1     
  Lines         8684     8708   +24     
========================================
+ Hits          8616     8640   +24     
  Misses          68       68           
Files with missing lines Coverage Δ
include/boost/url/impl/decode.hpp 100.00% <100.00%> (ø)
src/detail/decode.cpp 100.00% <ø> (ø)
src/detail/normalize.cpp 99.30% <ø> (ø)
src/detail/segments_iter_impl.cpp 99.19% <ø> (ø)
src/pct_string_view.cpp 100.00% <ø> (ø)
src/url_base.cpp 99.66% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bbe9700...24937d3. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@vinniefalco
Copy link
Member

Don't we already have a string token for that?

I mean that I will change my code to use a StringToken api

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add free percent-decoding helpers that mirror encode

3 participants