Conversation
…le styles in the form.
gregjkal
left a comment
There was a problem hiding this comment.
Looking really good! Few requests.
…, button design adjustments, and the image input for create post is still missing.
julhoang
left a comment
There was a problem hiding this comment.
Hey @herzog0 , thank you for continuing to push this forward – I know it's been a heavy lift given the complexity and scope of what we started with. I've left more comments below. I'm happy to jump on a huddle to discuss more if it's quicker/more helpful. Really appreciate your patience with this one! 🙏
static/css/v3/inputs-page.css
Outdated
There was a problem hiding this comment.
(sorry not sure why this comment got left out from the review round above)
I think this entire file can be deleted since none of these styles seem to be referenced from anywhere. 👀🪓
There was a problem hiding this comment.
Almost none 😭 the two ones at the bottom are. I'll delete this file and see if I can fit those extra classes somewhere, if they're really needed.
fixes issue where the first submission attempt would cause an error saying the content wasn't filled
Issue: #2111
Summary & Context
This pull request introduces a new version of the Create Post component. It also introduces some input component variants, new event triggering mechanisms for dropdowns and adds a small adaptation in the backend, so it supports input validation when knocking on endpoints for this new component.
Changes
news/create_v3.htmltemplate for post creation.core/views.pyandnews/views.pyto conditionally serve V3 templates and populate context data (like dropdown options and initial values) for the modernized post creation flow when thev3flag is active.Although I did my best to try and review what I could, there's much work from the previous iteration of developers that I don't clearly understand, like why we're importing the whole WYSIWYG js file in this branch while
developalready has that file, or why wasn't it updated in a separate branch and then merged to this one.Screenshots
Self-review Checklist
Frontend