Skip to content

Form post wisiwyg#2149

Open
DrJfrost wants to merge 72 commits intodevelopfrom
form-post-wisiwyg
Open

Form post wisiwyg#2149
DrJfrost wants to merge 72 commits intodevelopfrom
form-post-wisiwyg

Conversation

@DrJfrost
Copy link
Copy Markdown
Collaborator

@DrJfrost DrJfrost commented Mar 10, 2026

Issue: #2111

Summary & Context

This pull request introduces a new version of the Create Post component. It also introduces some input component variants, new event triggering mechanisms for dropdowns and adds a small adaptation in the backend, so it supports input validation when knocking on endpoints for this new component.

Changes

  • WYSIWYG Editor Integration: Implements a basic no-JavaScript fallback on top of some fixes.
  • V3 Post Creation Form: Introduces a new news/create_v3.html template for post creation.
  • Form Component Styling Overhaul: Improves styles in js-less versions of dropdowns, comboboxes and input.
  • Backend Integration: Updates core/views.py and news/views.py to conditionally serve V3 templates and populate context data (like dropdown options and initial values) for the modernized post creation flow when the v3 flag is active.
  • UI Refinements: Includes minor design corrections across V3 components, such as wrong variable names, coloring and font sizes.

‼️ Risks & Considerations ‼️

Although I did my best to try and review what I could, there's much work from the previous iteration of developers that I don't clearly understand, like why we're importing the whole WYSIWYG js file in this branch while develop already has that file, or why wasn't it updated in a separate branch and then merged to this one.

Screenshots

  • Desktop Light Mode
image
  • Desktop Dark Mode
image
  • Mobile
image

Self-review Checklist

  • Tag at least one team member from each team to review this PR
  • Link this PR to the related GitHub Project ticket

Frontend

  • UI implementation matches Figma design
  • Tested in light and dark mode
  • Responsive / mobile verified
  • Accessibility checked (keyboard navigation, etc.)
  • Ensure design tokens are used for colors, spacing, typography, etc. – No hardcoded values
  • Test without JavaScript (if applicable)
  • No console errors or warnings

Copy link
Copy Markdown
Collaborator

@gregjkal gregjkal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking really good! Few requests.

Copy link
Copy Markdown
Collaborator

@julhoang julhoang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @DrJfrost , I added some comments mostly around UI styling but just wanted to say overall this is looking really great!

Copy link
Copy Markdown
Collaborator

@julhoang julhoang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @herzog0 , thank you for continuing to push this forward – I know it's been a heavy lift given the complexity and scope of what we started with. I've left more comments below. I'm happy to jump on a huddle to discuss more if it's quicker/more helpful. Really appreciate your patience with this one! 🙏

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(sorry not sure why this comment got left out from the review round above)
I think this entire file can be deleted since none of these styles seem to be referenced from anywhere. 👀🪓

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost none 😭 the two ones at the bottom are. I'll delete this file and see if I can fit those extra classes somewhere, if they're really needed.

@herzog0 herzog0 requested a review from julhoang April 2, 2026 00:44
@herzog0 herzog0 dismissed stale reviews from gregjkal and themself April 2, 2026 00:45

addressed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Additional Input Component Variants Webpage UI: Create a Post

5 participants