-
Notifications
You must be signed in to change notification settings - Fork 26
Story 2127: Learn Page Implementation #2243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Changes from all commits
09dee21
5ad3abe
28610ec
7725e9f
a9b9372
bdd3c28
1226495
3315fe5
2570cac
c72a2f8
20c5bd7
2f0b0f6
0f68434
8ae70da
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -9,18 +9,27 @@ | |
| .learn-card__row { | ||
| display: flex; | ||
| align-items: flex-start; | ||
| gap: var(--space-large, 16px); | ||
| gap: var(--space-large); | ||
| align-self: stretch; | ||
| flex-direction: row; | ||
| } | ||
|
|
||
| @media (max-width: 696px) { | ||
| .learn-card__link-column { | ||
| gap: var(--space-s); | ||
| } | ||
|
|
||
| @media (max-width: 1280px) { | ||
| .learn-card__row { | ||
| flex-direction: column; | ||
| } | ||
|
|
||
| .learn-card .square-card-image { | ||
| flex: 1 0 auto; | ||
| aspect-ratio: 16/9; | ||
| } | ||
|
|
||
| .learn-card__link-column { | ||
| margin-bottom: var(--space-xxl); | ||
| } | ||
| } | ||
|
|
||
|
|
@@ -34,62 +43,66 @@ | |
| } | ||
|
|
||
| .learn-card__title { | ||
| color: var(--color-text-primary, #050816); | ||
| color: var(--color-text-primary); | ||
|
|
||
| /* Display/Desktop/Medium/Large */ | ||
| font-family: var(--font-display, "Mona Sans Display SemiCondensed"); | ||
| font-size: var(--font-size-large, 24px); | ||
| font-family: var(--font-display); | ||
| font-size: var(--font-size-large); | ||
| font-weight: var(--font-weight-medium); | ||
| line-height: var(--tight); | ||
| /* 24px */ | ||
| line-height: var(--line-height-tight); | ||
| letter-spacing: -0.24px; | ||
| } | ||
|
|
||
| .learn-card__text { | ||
| color: var(--color-text-secondary, #585A64); | ||
| color: var(--color-text-secondary); | ||
|
|
||
| /* Sans/Desktop/Regular/Base */ | ||
| font-family: var(--font-sans, "Mona Sans VF"); | ||
| font-size: var(--font-size-base, 16px); | ||
| font-weight: var(--font-weight-regular); | ||
| /* 19.2px */ | ||
| font-family: var(--font-sans); | ||
| font-size: var(--font-size-base); | ||
| font-weight: var(--font-weight-medium); | ||
| letter-spacing: -0.16px; | ||
| } | ||
|
|
||
| .learn-card__link-container { | ||
| display: flex; | ||
| min-width: 128px; | ||
| align-items: center; | ||
| gap: var(--space-s, 4px); | ||
| gap: var(--space-s); | ||
| } | ||
|
|
||
| .learn-card__link-icon { | ||
| fill: var(--color-icon-primary); | ||
| } | ||
|
|
||
| .learn-card__link-container:hover { | ||
| color: var(--color-text-link-accent); | ||
| } | ||
|
|
||
| .learn-card__link-container:hover .learn-card__link-icon { | ||
| fill: var(--color-text-link-accent); | ||
| } | ||
|
|
||
| .learn-card__link { | ||
| font-size: var(--font-sizes-small, 14px); | ||
| font-size: var(--font-size-small); | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This might be out-of-scope but I think this link should be its own component, see Figma here. Feel free to leave this to a separate ticket if you don't feel like adding it here! This current link is just missing font-weight 500 and a hover color.
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It did need some updating on styling, but I'm not sure it is used elsewhere? If it is, happy to spin it off as a separate item! |
||
| font-weight: var(--font-weight-medium); | ||
| line-height: 124%; | ||
| /* 17.36px */ | ||
| letter-spacing: -0.14px; | ||
| text-decoration-line: underline; | ||
| text-decoration-style: solid; | ||
| text-decoration-skip-ink: auto; | ||
| text-decoration-thickness: 7.5%; | ||
| /* 1.05px */ | ||
| text-underline-offset: 15.2%; | ||
| /* 2.128px */ | ||
| text-underline-position: from-font; | ||
| } | ||
|
|
||
|
|
||
| .learn-card__link-tag { | ||
| text-decoration: none; | ||
| color: inherit; | ||
| } | ||
|
|
||
| .learn-card__link-tag:focus-visible { | ||
| outline: none; | ||
| } | ||
|
|
||
| .learn-card__link-tag:focus-visible .learn-card__link-container { | ||
| outline: 2px solid Highlight; | ||
| outline: 2px solid -webkit-focus-ring-color; | ||
|
|
||

Uh oh!
There was an error while loading. Please reload this page.