Merged
Conversation
Like coreos/rpm-ostree#5352 Signed-off-by: Colin Walters <[email protected]>
jeckersb
approved these changes
May 27, 2025
Collaborator
jeckersb
left a comment
jeckersb
left a comment
There was a problem hiding this comment.
Looks sane to me.
Not sure what's going on with that failed test though. I tried to reproduce it in a stream9 container and everything is working fine for me. Only thing I noticed was this bit in the test:
Which seems a bit weird to call export_container() twice like that. I didn't dig into it to fully wrap my head around it but maybe there's some potential for that to go wrong? I'll post a follow-up to fix that (unless there's some non-obvious reason it's like that).
jeckersb
added a commit
to jeckersb/bootc
that referenced
this pull request
May 27, 2025
Just something weird I noticed when looking at bootc-dev#1328 Signed-off-by: John Eckersberg <[email protected]>
jeckersb
added a commit
to jeckersb/bootc
that referenced
this pull request
Jun 12, 2025
This was changed previously in bootc-dev#1328, this reverts to the old format. Signed-off-by: John Eckersberg <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Like coreos/rpm-ostree#5352