Skip to content

Fix documentation on ProjectionFactorPPPC #1004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
varunagrawal merged 3 commits into from
Jan 3, 2022
Merged

Fix documentation on ProjectionFactorPPPC #1004

varunagrawal merged 3 commits into from
Jan 3, 2022

Conversation

@dwisth
Copy link
Contributor

@dwisth dwisth commented Jan 3, 2022

A couple of small changes to ProjectionFactorPPPC:

  • Remove excess constructor, use default arguments instead
  • Fix construction documentation
  • Make some variables const where possible

@dwisth dwisth requested a review from varunagrawal January 3, 2022 05:45
varunagrawal
varunagrawal approved these changes Jan 3, 2022
View reviewed changes
Copy link
Contributor

@varunagrawal varunagrawal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@varunagrawal varunagrawal merged commit 6bfad39 into develop Jan 3, 2022
@varunagrawal varunagrawal deleted the fix/projection-factor-pppc-documentation branch January 3, 2022 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@varunagrawal varunagrawal varunagrawal approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dwisth @varunagrawal