More DecisionTree improvements #1005
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
dellaert
commented
Jan 4, 2022
dellaert
commented
- Added some depth-first methods: fold, visit, visitWith
- Use template for functions rather than std::functions, which matches against lambdas and function pointers as well.
# Conflicts: # gtsam/discrete/tests/testDecisionTree.cpp
# Conflicts: # gtsam/discrete/DecisionTree-inl.h # gtsam/discrete/DecisionTree.h
ProfFan
approved these changes
Jan 4, 2022
Collaborator
ProfFan
left a comment
ProfFan
left a comment
There was a problem hiding this comment.
Approving sans one comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.