User-provided hook within the internal loop of non-linear optimizers #586
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
varunagrawal
requested changes
Nov 9, 2020
Contributor
varunagrawal
left a comment
varunagrawal
left a comment
There was a problem hiding this comment.
LGTM but requesting some minor updates.
varunagrawal
added
enhancement
varunagrawal
approved these changes
Nov 16, 2020
| * }; | ||
| * \endcode | ||
| * or to the result of a properly-formed `std::bind` call. | ||
| */ |
| boost::optional<Ordering> ordering; ///< The optional variable elimination ordering, or empty to use COLAMD (default: empty) | ||
| IterativeOptimizationParameters::shared_ptr iterativeParams; ///< The container for iterativeOptimization parameters. used in CG Solvers. | ||
|
|
||
| NonlinearOptimizerParams() = default; |
Contributor
There was a problem hiding this comment.
I remember seeing a comment from @dellaert about having variables before constructors, so he'll be happy about this one. 😄
Contributor
|
I believe the build is failing because Actions got rid of Boost 1.69 on Linux virtual environments, opting instead for 1.72. We already landed the PR to upgrade the workflows, but I guess this PR was created before that. I'll push a merge. |
Member
Author
|
@dellaert Should we merge this one? Do you want to take a look first? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the example in the new unit test.
This allows progress reports, debugging, GUI updating, etc. during non-linear optimizers are running.
Note: this PR builds upon #585 .