Templated PoseToPointFactor #955
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dellaert
approved these changes
Dec 8, 2021
Member
dellaert
left a comment
dellaert
left a comment
There was a problem hiding this comment.
Cool! Feel free to merge after the CI passes :-)
dwisth
approved these changes
Dec 8, 2021
Contributor
dwisth
left a comment
dwisth
left a comment
There was a problem hiding this comment.
Looks good to me @lucacarlone - it's a nice way to extend this factor to other use cases.
Same as Frank, I'm happy for you to merge once CI passes.
Member
|
I merged, even though one of the IC checks failed: I checked and it was an OS loading problem. 99.99% non-issue. |
Contributor
Author
|
that was fast! thanks @dellaert ! |
Member
|
Small PR's are always easier ;-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.