Wrap Update #965
Merged
Wrap Update #965
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
086be59be Merge pull request #135 from borglab/feature/matlab_default_args d3a0a8a15 don't allow out-of-order default argument specifications in matlab 702986de3 take out unit test with illegal default argument specification (according to c++ rules) 6166dfa4d update functions.i unit test expected and fix cyclic copy 4a4003273 class wrapper working b7e4d3522 Update class_wrapper matlab unit test b9409f10c placeholder folder for unit test "actual" folder 5e2aa1511 fix unit test for `DefaultFuncInt` only (others not fixed yet) git-subtree-dir: wrap git-subtree-split: 086be59bed87cc8a9c3f28b4cb99566b59bc3fda
gchenfc
approved these changes
Dec 13, 2021
Contributor
Author
|
Thanks for the review @gchenfc. I am going to let @mattking-smith submit a review before I merge. :) |
mattking-smith
approved these changes
Dec 14, 2021
I looked through everything. I do not see a problem with this. Feel free to merge @varunagrawal |
Contributor
Author
|
Now we just have to figure out the memory leak and we should be good to go with the Matlab wrapper 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update adds support to the Matlab wrapper for default arguments.