Streamlined dot methods #971
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- separate file - inherit from DotWriter - made dot/dot/saveGraph the pattern - deprecated saveGraph(ostream) method
varunagrawal
approved these changes
Dec 21, 2021
Contributor
varunagrawal
left a comment
varunagrawal
left a comment
There was a problem hiding this comment.
This is great stuff! I have a few comments, but they can be addressed now or later. 🙂
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Driven by tests in discrete and nonlinear, and two notebooks, I refactored dot methods:
inference
discrete
nonlinear
TODO: Gaussian still needs to conform. It's a bit tricky as GaussianBayesNet has to be made a derived class of BayesNet (again?)
Example output from DiscreteSwitching.ipynb:
bn.svg.pdf
fg.svg.pdf
bt.svg.pdf