Fix issue where X-Amz-Content-SHA256 was being set twice #388
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
More fallout from the fact that we resign requests. There was this Content-SHA256 header that did not have the "delete if already present" logic, which would cause errors when retrying S3 sigv4 requests because we would not be signing the requests properly. I've added a unittest as well as an integration test to ensure we don't regress on this in the future.
Contributor
|
Looks good. 🚢 |
jamesls
added a commit
to aws/aws-cli
that referenced
this pull request
Nov 24, 2014
kyleknap
added a commit
to aws/aws-cli
that referenced
this pull request
Nov 26, 2014
* release-1.6.5: Bumping version to 1.6.5 Update changelog Added support for inline parameter values Support for parameter objects and values [EMR] Add mutual exclusive validation on --use-default-roles and --ec2-attributes InstanceProfile options in create-cluster command [EMR] Add mutual exclusive validation on --use-default-roles and --service-role options in create-cluster command [EMR] Add Hue to create-cluster examples Updated changelog Do not check md5 for downloading kms objects Add boto/botocore#388 to changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More fallout from the fact that we resign requests. There
was this Content-SHA256 header that did not have the "delete if
already present" logic, which would cause errors when retrying
S3 sigv4 requests because we would not be signing the requests
properly.
I've added a unittest as well as an integration test to ensure
we don't regress on this in the future.
cc @kyleknap @danielgtaylor