BM-736: Targeted benchmark proving #507
Conversation
willemolding
requested review from
capossele,
Wollac,
zeroecco,
austinabell,
rlukata and
a team
as code owners
There was a problem hiding this comment.
Skimming this, it's unclear to me if trying to target specific provers with orders, why we would not just selectively send orders to specific addresses? Feels like it should be handled at the order stream server level? If you really want to skip preflight, you just have the prover add the benchmark program ID to skip_preflight_ids?
Also perhaps I'm misreading the impl, but this means for brokers that are not being benchmarked will try to process the order and fail because they don't have the secret prefix? This seems unideal.
| Some(v) => Helper(v).serialize(serializer), | ||
| None => serializer.serialize_none(), | ||
| } | ||
| } | ||
|
|
||
| pub fn deserialize<'de, D>(deserializer: D) -> Result<Option<Vec<u8>>, D::Error> | ||
| where | ||
| D: serde::Deserializer<'de>, | ||
| { | ||
| #[derive(Deserialize)] | ||
| struct Helper(#[serde(with = "hex_serde")] Vec<u8>); | ||
|
|
||
| let helper = Option::deserialize(deserializer)?; | ||
| Ok(helper.map(|Helper(v)| v)) |
There was a problem hiding this comment.
This may work for toml/json, just noting that this will not work for some serialization protocols. Probably won't ever matter in our case, but wondering why handling Option case implicitly. serde_with crate would remove the need for all of this.
|
Moved this to draft to indicate we do not intend to merge as is, after discussion on the approach here. |
Closes #485