Skip to content

Align traceparent with Sentry's sentry-trace header #1639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 21, 2024
Merged

Conversation

jamescrowley
Copy link
Contributor

@jamescrowley jamescrowley commented Oct 11, 2024

The span id within transparent will not match, but the trace id itself will. Can review if/when Sentry support for traceparent getsentry/sentry-javascript#11171 (comment) progresses.

@jamescrowley jamescrowley changed the title Align Sentry traceid with traceparent Align Sentry's sentry-trace with traceparent headers Oct 11, 2024
@jamescrowley jamescrowley changed the title Align Sentry's sentry-trace with traceparent headers Align traceparent with Sentry's sentry-trace header Oct 11, 2024
Copy link

codecov bot commented Oct 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.93%. Comparing base (ef23ce8) to head (0d5e64f).
Report is 11 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1639      +/-   ##
==========================================
- Coverage   84.11%   83.93%   -0.18%     
==========================================
  Files         232      232              
  Lines       14343    14373      +30     
  Branches     1511     1511              
==========================================
  Hits        12064    12064              
- Misses       2240     2270      +30     
  Partials       39       39              
Flag Coverage Δ
backend 99.03% <ø> (ø)
frontend 77.59% <ø> (-0.24%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jamescrowley
Copy link
Contributor Author

jamescrowley commented Oct 14, 2024

@pylipp @HaGuesto confirmed this works in staging. traceid aligned between sentry/gcp. The span id does not, as sentry still does it's own thing wrapping requests, but I think this will do us for now until Sentry supports direct integration.
Screenshot 2024-10-14 at 18 15 33

Screenshot 2024-10-14 at 18 16 04

@pylipp
Copy link
Contributor

pylipp commented Oct 21, 2024

@pylipp pylipp merged commit 1414a7a into master Oct 21, 2024
11 checks passed
@pylipp pylipp deleted the sentryTracing branch October 21, 2024 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants