Fix Boolean and Number condition for FEEL static properties #207
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philippfromme
force-pushed
the
boolean-condition-fix
branch
from
a3531c5 to
9f5f6b3
Compare
| // given | ||
| const element = changeTemplate('Task_1', numberTemplate); | ||
| // TODO(@jarekdanielak): To be implemented as part of | ||
| // https://github.com/bpmn-io/bpmn-js-element-templates/issues/195 |
Contributor
There was a problem hiding this comment.
The PR description says #195 is going to be closed by the PR so how can this remain a TODO?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #192
Closes #195
Proposed Changes
This ensures that property value and the condition matcher are both parsed from FEEL expressions to their target types, e.g.
truematches"=true","=5"matches5etc.Removed test
The removed test states that a condition "should not match when property type is Number but condition expect string". I think the condition has no way to expect a certain type. It expects the type of the related property, and we should try to match the types, in the spirit of doing the hard work for the user.
Try out
npm startand apply "Condition" or "Condition (Number)" templates. Click around the custom properties.Checklist
Ensure you provide everything we need to review your contribution:
Closes {LINK_TO_ISSUE}orRelated to {LINK_TO_ISSUE}@bpmn-io/srtool