[CLOSED] Sort languages via their display names

[core-ai-bot]

Issue by MarcelGerber
Monday Apr 21, 2014 at 19:32 GMT
Originally opened as adobe/brackets#7593

---

This fixes #7516.

---

MarcelGerber included the following code: https://github.com/adobe/brackets/pull/7593/commits

[core-ai-bot]

Comment by redmunds
Tuesday Apr 22, 2014 at 23:13 GMT

---

Is there a reason that italiano, norsk, polski, and suomi are not capitalized?

[core-ai-bot]

Comment by TomMalbran
Tuesday Apr 22, 2014 at 23:48 GMT

---

I think that English should be sorted to, so that we have English (US) and English (UK) together.

[core-ai-bot]

Comment by MarcelGerber
Wednesday Apr 23, 2014 at 01:31 GMT

---

@redmunds Looks like it's intended to do so - take a look at https://www.google.com/preferences#languages.

@TomMalbran Don't know what to do here, and English (UK) does not yet much in Brackets (basically nothing...).

[core-ai-bot]

Comment by redmunds
Wednesday Apr 23, 2014 at 04:12 GMT

---

@SAPlayer

Looks like it's intended to do so - take a look at https://www.google.com/preferences#languages.

I don't think that's a good example, since some of the ones that we have capitalized are lowercase there. It's not really related to this change, so we don't need to worry about it.

[core-ai-bot]

Comment by MarcelGerber
Wednesday Apr 23, 2014 at 12:52 GMT

---

@redmunds Changes pushed. We should consider looking at the locale names a second time, Google and Wikipedia state other names sometimes (or other casing). I could do that if you want.

[core-ai-bot]

Comment by redmunds
Wednesday Apr 23, 2014 at 14:26 GMT

---

@TomMalbran

I think that English should be sorted to, so that we have English (US) and English (UK) together.

This dialog was designed to help those translating from English (US) to some other language, so that's why it was placed at the top. This PR is about ordering the other items in the list, so we'll just keep it there for now.

[core-ai-bot]

Comment by redmunds
Wednesday Apr 23, 2014 at 14:29 GMT

---

Looks good. Merging.

[core-ai-bot]

Comment by TomMalbran
Wednesday Apr 23, 2014 at 16:11 GMT

---

In that case, we could place the other English locales at the top too?

[core-ai-bot]

Comment by MarcelGerber
Wednesday Apr 23, 2014 at 18:00 GMT

---

Well, at least for now English (UK) doesn't differ from English (US) in core. It would be nice to see them beneath each other, but that would possibly require hardcoding en-gb to the top, which isn't the best.

[core-ai-bot]

Comment by peterflynn
Thursday Apr 24, 2014 at 01:21 GMT

---

@TomMalbran@SAPlayer Actually, do you know why we bother forcing "English (US)" to the top of the list? From a user standpoint, there's nothing special about "English (US)" -- users don't care that it's the "root" language under the hood... (But of course I can see why we'd want "System Default" at the top -- definitely not suggesting changing that).