Remove the markers to disable specific slowly running tests#348
Merged
alessandrofelder merged 7 commits intomainfrom May 17, 2024
Merged
Remove the markers to disable specific slowly running tests#348alessandrofelder merged 7 commits intomainfrom
alessandrofelder merged 7 commits intomainfrom
Conversation
This was referenced May 14, 2024
Merged
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #348 +/- ##
==========================================
+ Coverage 86.47% 87.13% +0.65%
==========================================
Files 27 27
Lines 1220 1220
==========================================
+ Hits 1055 1063 +8
+ Misses 165 157 -8 ☔ View full report in Codecov by Sentry. |
Member
Author
|
@alessandrofelder I've finally managed to get the tests to pass 🎉 For some reason |
Member
Author
|
Windows tests seem to be taking a long time, but that may be some temporary issue with GH actions. If it persists I'll look into it. |
alessandrofelder
approved these changes
May 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All tests will either run "normally", or have been disabled if the functionality is broken (see #347).
Developed on top of #346 so that should be merged first. Tests will fail until the new version of
brainglobe-utilsis released.Closes #285
Docs updated here: brainglobe/brainglobe.github.io#185