Skip to content

Comments

Fix jagged renderings in cartoon mode and restore default shader style#352

Merged
alessandrofelder merged 2 commits intomainfrom
fix-outlines
May 15, 2024
Merged

Fix jagged renderings in cartoon mode and restore default shader style#352
alessandrofelder merged 2 commits intomainfrom
fix-outlines

Conversation

@adamltyson
Copy link
Member

Fixes #327

TBH I don't really know what's going on here, but the examples work, the tests pass and Marco says it's fine so 🤷

@codecov
Copy link

codecov bot commented May 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.47%. Comparing base (453ced2) to head (f43d02a).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #352      +/-   ##
==========================================
+ Coverage   85.08%   86.47%   +1.39%     
==========================================
  Files          27       27              
  Lines        1220     1220              
==========================================
+ Hits         1038     1055      +17     
+ Misses        182      165      -17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alessandrofelder alessandrofelder merged commit fe39118 into main May 15, 2024
@alessandrofelder alessandrofelder deleted the fix-outlines branch May 15, 2024 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Silhouettes (in cartoon mode) have a jagged appearance when the scene is rotates

2 participants