Skip to content

Comments

Pin vtk#397

Merged
adamltyson merged 1 commit intomainfrom
pin-vtk
Dec 9, 2024
Merged

Pin vtk#397
adamltyson merged 1 commit intomainfrom
pin-vtk

Conversation

@IgorTatarnikov
Copy link
Member

Pin vtk version to fix Windows CI tests

@IgorTatarnikov
Copy link
Member Author

Pinning vtk fixed the Windows test failing on CI. However, currently http://api.brain-map.org/api/v2 is down causing the gene expression smoke tests to fail.

@alessandrofelder
Copy link
Member

Should we merge this given the failures are unrelated to the VTK problem?

@codecov
Copy link

codecov bot commented Dec 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.62%. Comparing base (5434403) to head (b4b17f3).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #397   +/-   ##
=======================================
  Coverage   86.62%   86.62%           
=======================================
  Files          27       27           
  Lines        1241     1241           
=======================================
  Hits         1075     1075           
  Misses        166      166           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@IgorTatarnikov IgorTatarnikov marked this pull request as ready for review December 9, 2024 10:32
@IgorTatarnikov IgorTatarnikov requested a review from a team December 9, 2024 10:32
@IgorTatarnikov
Copy link
Member Author

Seems the problems at http://api.brain-map.org/api/v2 have resolved

@adamltyson
Copy link
Member

Thanks @IgorTatarnikov. I've raised #399 to revert this at some point.

@adamltyson adamltyson merged commit 167c9f2 into main Dec 9, 2024
@adamltyson adamltyson deleted the pin-vtk branch December 9, 2024 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants