Merged
Conversation
Member
Author
|
Pinning |
Member
|
Should we merge this given the failures are unrelated to the VTK problem? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #397 +/- ##
=======================================
Coverage 86.62% 86.62%
=======================================
Files 27 27
Lines 1241 1241
=======================================
Hits 1075 1075
Misses 166 166 ☔ View full report in Codecov by Sentry. |
Member
Author
|
Seems the problems at http://api.brain-map.org/api/v2 have resolved |
Closed
adamltyson
approved these changes
Dec 9, 2024
Member
|
Thanks @IgorTatarnikov. I've raised #399 to revert this at some point. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pin vtk version to fix Windows CI tests