BUG `create_external_database_if_not_exists` looks like not working.

[piotr-vimn]

Configuration:

# External schema using AWS Glue Data Catalog
resource "redshift_schema" "data_catalog" {
  name  = "db_schema"
  owner = redshift_user.owne.name
  external_schema {
    database_name = "db" 
    data_catalog_source {
      iam_role_arns = [
        "arn:aws:iam::....:role/....",
      ]
      create_external_database_if_not_exists = true 
    }
  }
}

After turn on debug mode:

redshift_schema.data_catalog: Creating...
2021-10-04T16:20:57.592+0200 [INFO]  Starting apply for redshift_schema.data_catalog
2021-10-04T16:20:57.593+0200 [DEBUG] redshift_schema.data_catalog: applying the planned Create change
2021-10-04T16:20:58.684+0200 [INFO]  provider.terraform-provider-redshift_v0.4.1: 2021/10/04 16:20:58 [DEBUG] creating external schema: CREATE EXTERNAL SCHEMA "db_schema" FROM DATA CATALOG DATABASE 'db' IAM_ROLE 'arn:aws:iam::....:role/....': timestamp=2021-10-04T16:20:58.684+0200
2021-10-04T16:20:58.823+0200 [INFO]  provider.terraform-provider-redshift_v0.4.1: 2021/10/04 16:20:58 [DEBUG] setting schema owner: ALTER SCHEMA "db_schema" OWNER TO "owner": timestamp=2021-10-04T16:20:58.823+0200
2021-10-04T16:21:02.523+0200 [INFO]  provider.terraform-provider-redshift_v0.4.1: 2021/10/04 16:21:02 [DEBUG]: sql: transaction has already been committed or rolled back: timestamp=2021-10-04T16:21:02.523+0200

Bug: There is missing create external database if not exists

Environment:

Terraform v1.0.8
on darwin_amd64
+ provider registry.terraform.io/brainly/redshift v0.4.1
+ provider registry.terraform.io/hashicorp/aws v3.61.0
+ provider registry.terraform.io/hashicorp/random v3.1.0

[piotr-vimn]

After investigation.
Looks like issue is in the resource_redshift_schema.go - lines 174-177.

Once I remove DiffSuppressFunc in the

"create_external_database_if_not_exists": {
	Type:     schema.TypeBool,
	Optional: true,
	Default:  false,
	DiffSuppressFunc: func(k, old, new string, d *schema.ResourceData) bool {
		return true // this attribute only applies at create time so we should never flag it as a change
	},
	// ...
}

parameter is passing properly.

[ozturkberkay]

@winglot Has this fixed yet?

[winglot]

@ozturkberkay
I'm currently working on a fix.
Since, simply removing DiffSuppressFunc only fixes the problem partially, I expect to finish and release the change on Monday.