This repository was archived by the owner on Jan 17, 2025. It is now read-only.
Fix readSchemaGrants and readTableGrants for groups#76
Merged
winglot merged 1 commit intobrainly:masterfrom Aug 4, 2022
olivermeyer:fix-read-table-and-schema-grants
Merged
Fix readSchemaGrants and readTableGrants for groups#76winglot merged 1 commit intobrainly:masterfrom olivermeyer:fix-read-table-and-schema-grants
winglot merged 1 commit intobrainly:masterfrom
olivermeyer:fix-read-table-and-schema-grants
Conversation
Author
|
@winglot please can you take a look at this? |
winglot
approved these changes
Aug 4, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the readSchemaGrants and readTableGrants functions. They currently don't work correctly if two groups start with the same name and have different permissions: in our case, we have a
datagroup and adata_englegacy group and the queries were returning the privileges for thedata_enggroup, even whengr.groname == data.