relocate subprocess_popen_text + subprocess_terminate to easybuild.tools.run, import create_base_metaclass + mk_wrapper_baseclass from easybuild.base.wrapper in py2vs3/*.py #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s by importing from easybuild.base.wrapper in py2vs3/*.py
boegel
changed the title
branfosj
pushed a commit
that referenced
this pull request
Feb 11, 2025
add extra test case for make_module_req
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@branfosj for easybuilders#4229
easybuild.tools.asyncprocessis 3rd party code (which we maybe can even ditch if we only need to support for Python >= 3.6), so I think it's better to add thesubprocess_popen_textandsubprocess_terminatetoeasybuild.tools.runinstead (and to avoid still having a copy inpy2vs3/py3, we can also there import them fromeasybuild.tools.run)