-
Notifications
You must be signed in to change notification settings - Fork 66
Upgrade commonmarker and html-pipeline #175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hey @brettchalupa 👋 I wanted to check to see what your plans were with this change since this PR was closed. Is this still something you're looking at? Thanks for any info! I'm primarily looking at blockers to a Ruby 4 upgrade and this gem was flagged due to its dependency on commonmarker 0.23.x which isn't compatible with Ruby 4 (at least its gemspec doesn't allow it). |
|
@obrie I want to take this to the finish line but I haven't had time. My intent is to release a v6 of the gem with this and all of the recent changes. If I merge this into |
Gets them on their latest versions. This means breaking changes due to major revisions in how those gems work. Fixes #162
f476d56 to
ffb9eea
Compare
|
@obrie if you point your app to use the |
|
There may be more dependency revisions I need to make to support Ruby 4 based on https://github.com/brettchalupa/graphql-docs/actions/runs/20720237865/job/59481720488?pr=177 failing but working on it 👍 |
|
Thanks @brettchalupa! We'll give it a go and let you know |
|
Just confirming, looks like testing will be blocked on the release of gjtorikian/html-pipeline#427 |
|
@obrie awesome, thank you. I've subscribed to that upstream PR and will work on updating accordingly once it ships 👀 |
|
FYI upstream shipped html-pipeline shipped a new version, but I'm now unfortunately blocked on unicorn/kgio not being compatible with Ruby 4: https://yhbt.net/kgio-public/[email protected]/T/#u Once I address this, I'll be able to run our webserver and begin testing our usage of graphql-docs. |
|
@obrie sounds good, thanks! I got CI running Ruby 4 and tested graphql-docs locally, all seems well 👍 |
|
I was able to run our application this afternoon and can confirm everything is looking good on our end 🎉 Thanks for all the effort! |
|
@obrie awesome, glad to hear it's working well. Thanks for collaborating and testing! 🎊 |
Gets them on their latest versions. This means breaking changes due to
major revisions in how those gems work.
Fixes #162
Tasks Before Merge