Skip to content

Conversation

@brettchalupa
Copy link
Owner

@brettchalupa brettchalupa commented Oct 16, 2025

Gets them on their latest versions. This means breaking changes due to
major revisions in how those gems work.

Fixes #162

Tasks Before Merge

  • review code
  • test the generated docs thoroughly

@obrie
Copy link
Contributor

obrie commented Jan 2, 2026

Hey @brettchalupa 👋 I wanted to check to see what your plans were with this change since this PR was closed. Is this still something you're looking at? Thanks for any info!

I'm primarily looking at blockers to a Ruby 4 upgrade and this gem was flagged due to its dependency on commonmarker 0.23.x which isn't compatible with Ruby 4 (at least its gemspec doesn't allow it).

@brettchalupa
Copy link
Owner Author

@obrie I want to take this to the finish line but I haven't had time. My intent is to release a v6 of the gem with this and all of the recent changes. If I merge this into main, would you want to run off of that branch and test it out a bit? That'd be a big help for me to get this done.

@brettchalupa brettchalupa reopened this Jan 4, 2026
Gets them on their latest versions. This means breaking changes due to
major revisions in how those gems work.

Fixes #162
@brettchalupa brettchalupa force-pushed the upgrade-html-pipeline-and-commonmarker branch from f476d56 to ffb9eea Compare January 4, 2026 00:53
@brettchalupa brettchalupa marked this pull request as ready for review January 4, 2026 00:55
@brettchalupa brettchalupa merged commit 32afaeb into main Jan 5, 2026
8 checks passed
@brettchalupa brettchalupa deleted the upgrade-html-pipeline-and-commonmarker branch January 5, 2026 15:28
@brettchalupa
Copy link
Owner Author

@obrie if you point your app to use the main branch of this repo, you can give it a test on Ruby 4 and see how it goes!

@brettchalupa
Copy link
Owner Author

brettchalupa commented Jan 5, 2026

There may be more dependency revisions I need to make to support Ruby 4 based on https://github.com/brettchalupa/graphql-docs/actions/runs/20720237865/job/59481720488?pr=177 failing but working on it 👍

@obrie
Copy link
Contributor

obrie commented Jan 5, 2026

Thanks @brettchalupa! We'll give it a go and let you know

@obrie
Copy link
Contributor

obrie commented Jan 5, 2026

Just confirming, looks like testing will be blocked on the release of gjtorikian/html-pipeline#427

@brettchalupa
Copy link
Owner Author

@obrie awesome, thank you. I've subscribed to that upstream PR and will work on updating accordingly once it ships 👀

@obrie
Copy link
Contributor

obrie commented Jan 6, 2026

FYI upstream shipped html-pipeline shipped a new version, but I'm now unfortunately blocked on unicorn/kgio not being compatible with Ruby 4: https://yhbt.net/kgio-public/[email protected]/T/#u

Once I address this, I'll be able to run our webserver and begin testing our usage of graphql-docs.

@brettchalupa
Copy link
Owner Author

@obrie sounds good, thanks! I got CI running Ruby 4 and tested graphql-docs locally, all seems well 👍

@obrie
Copy link
Contributor

obrie commented Jan 6, 2026

I was able to run our application this afternoon and can confirm everything is looking good on our end 🎉 Thanks for all the effort!

@brettchalupa
Copy link
Owner Author

@obrie awesome, glad to hear it's working well. Thanks for collaborating and testing! 🎊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Upgrade html-pipeline and commonmarker

3 participants