Memory leak

[davetapley]

I'm getting a rather substantial memory leak, and I've isolated it to node-postgres, I don't know much more than that at the moment. It doesn't appear related to connection failures, so I believe it's different to #417.

Here's my initial repro on GitHub:

1. Create a new Heroku app.
2. heroku addons:add heroku-postgresql so we have a DB to connect to.
3. heroku labs:enable log-runtime-metricsso we can see the dyno memory usage.
4. Clone my test repo.
5. Push the test repo to the Heroku app.
6. heroku ps:scale work=1 to start doing work.
7. heroku logs --tail and watch for the sample#memory_rss output from the runtime metric lab.

If you heroku addons:add librato, wait a little, then heroku addons:open librato, you can see a graph of the leak, like this:

(that's 60 MB in < 20 mins for a script which does nothing but connect!)

---

Details:

Heroku version 9.3.3
node-postgres version 3.1.0 (using native, as I need SSL, per #25)
node 0.10.28

[davetapley]

To expand a little:

Here is my test file work.js, it has a three modes. If you run it with no env vars it'll just do connect(...) and done() and yet the leak still occurs. If the script looks a bit wonky it's because I converted it from coffescript 😄

Can someone just sanity check the file is okay?
It's about as basic as they come though.

[davetapley]

Ah, you may be able to disregard this (or at least call it the same as #417), my test script is passing truthy to done, because I'm an idiot and didn't RTFM 😉