-
Notifications
You must be signed in to change notification settings - Fork 778
Vendor getrandom 0.3
#2700
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Vendor getrandom 0.3
#2700
Conversation
briansmith
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking this on. Please post a new version with these changes and squash them all into one commit with a good commit message. Then I will review the updated version by diffing it with upstream. Also, please use an upstream commit that corresponds to a crates.io release of getrandom.
|
Sorry for getting back to this late - all the points should be addressed, and I'm using the upstream commit corresponding to v0.3.3 on crates.io. Once you've confirmed everything is good, I'll squash everything down to one commit. With With v0.3.4, the |
|
@briansmith Have you had a chance to look at this yet? |
This PR implements the "first PR" outlined here in #2341:
I needed to add
error.rsandutils.rsas well, since theErrorstruct and some utility functions were required by the other files.Currently, running
ringonwasm32-unknown-unknownrequires thegetrandom_backendconfig variable to be set in order forgetrandomto compile properly, but making the ergonomics smoother is outside the scope of PR.