arithmetic: Make Elem operations methods.
#2737
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make these things methods instead of freestanding functions, to make it easier to read/write code that uses them.
Make this a method instead of a freestanding function to make it easier to read/write code that uses it.
Make this a method instead of a freestanding function to make it easier to read/write code that uses it.
Make this a method instead of a freestanding function to make it easier to read/write code that uses it.
Make these methods instead of a freestanding function to make it easier to read/write code that uses them, but mostly to be consistent with other similar changes.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2737 +/- ##
=======================================
Coverage 96.61% 96.62%
=======================================
Files 201 201
Lines 20475 20460 -15
Branches 526 526
=======================================
- Hits 19782 19769 -13
+ Misses 577 576 -1
+ Partials 116 115 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.