Skip to content

Remove definitions of deprecated Error::description() and Error::cause(). #938

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 19, 2020

Conversation

briansmith
Copy link
Owner

No description provided.

@briansmith briansmith self-assigned this Jan 24, 2020
@briansmith
Copy link
Owner Author

This seems like a SemVer breaking change so I'll defer to the next major version bump to do this.

@akhilles
Copy link

akhilles commented Feb 28, 2020

I don't think this is a breaking change at the API-level since Error::source() was introduced in Rust 1.30.0 (I'm assuming the MSRV of ring is > 1.30). Also, std::error::Error still provides default implementations for Error::description() and Error::cause():

fn description(&self) -> &str {
    "description() is deprecated; use Display"
}

fn cause(&self) -> Option<&dyn Error> {
    self.source()
}

The behavior of Error::cause() would be unaffected, but the description string would change from "ring::error::Unspecified" to "description() is deprecated; use Display". Would that be considered a breaking change?

@briansmith briansmith added this to the 0.17.0 milestone May 15, 2020
@briansmith briansmith changed the base branch from master to main June 19, 2020 16:48
@briansmith briansmith force-pushed the b/error-deprecated branch from d406a1e to c47d4d6 Compare June 19, 2020 16:50
@briansmith briansmith merged commit f06811a into main Jun 19, 2020
@briansmith briansmith deleted the b/error-deprecated branch June 19, 2020 16:50
@briansmith
Copy link
Owner Author

@akhilles Thanks for your help!

@briansmith briansmith restored the b/error-deprecated branch November 23, 2020 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants