added CORS support #26
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| implicit def executionContext = actorRefFactory.dispatcher | ||
| def actorRefFactory = context | ||
| def possibleRoutes = baseRoute ~ workflowRoutes ~ swaggerService.routes | ||
| def possibleRoutes = cors { baseRoute ~ workflowRoutes ~ swaggerService.routes } |
There was a problem hiding this comment.
do we want cors for all of our routes or just swagger?
There was a problem hiding this comment.
we do, otherwise you get the no allow-origin header when you make a request
|
Is it going to be merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is for using snoop swagger UI from another server (e.g. apollo-api). You will need to add
origin = "http://apollo-api:8000" to the swagger section in snoop.conf.
I believe this should work. However due to the hardship setting up a proxy server locally, testing was limited.
According to this post swagger-api/swagger-ui#343, the apollo-api server may need to add useJQuery:true and xhr.withCredentials=true when initializing SwaggerUI in order to send along the cookie, eg :
new SwaggerUi({
url: "/api-docs",
dom_id: "swagger-ui-container",
useJQuery: true,
beforeSend: function(xhr){
xhr.withCredentials = true;
}
...