create-hash/md5

[fanatid]

var md5 = require('create-hash/md5')

should be

var createHash = require('create-hash')
function md5 (buf) { return createHash('md5').update(buf).digest() }

isn't it?

because

• nobody guarantee that file md5 will always exists
• you require js version instead openssl in node

ping @calvinmetcalf

[calvinmetcalf]

this intentionally grabs just the md5 stuff to avoid pulling in all of the sha and ripemd code when all that is needed is md5. Also since in context createCipher only ever does a single round we don't really need to worry about teh speed.

[fanatid]

I understand that is pulled only md5, but it's not right since this is not documented in create-hash?

[calvinmetcalf]

then lets document it in create-hash

On Mon, Mar 28, 2016 at 3:00 PM Kirill Fomichev [email protected]
wrote:

I understand that is pulled only md5, but it's not right since this is
not documented in create-hash?

—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#3 (comment)

[fanatid]

I prefer change require whole create-hash or extract md5 from create-hash

[dcousens]

Closing in favour of #6