Skip to content

Fix class expression and leaky function expr in alias assignment #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 25, 2019

Conversation

goto-bus-stop
Copy link
Member

I think this could actually be simplified again but for now this will do.

This fixes an issue where

exports.a = exports.b = class {}

generated invalid code, and an issue where

exports.a = exports.b = class a {}
exports.c = exports.d = function a {}

would turn the class/fn expressions into declaration statements, leaking the name to the parent scope.

@goto-bus-stop goto-bus-stop merged commit 9bcafb0 into master Feb 25, 2019
@goto-bus-stop goto-bus-stop deleted the fix-class-expr branch February 25, 2019 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant