Skip to content

current npm version 1.1.2 of package create-hash does not support md5 stream calcualtion #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
XiaoningLiu opened this issue Oct 18, 2016 · 3 comments
Assignees

Comments

@XiaoningLiu
Copy link

Hi,

For package create-hash, current npm version 1.1.2 doesn't support md5 calculation based on stream.

We need buffer all the data in memory and then calculate the md5.
It's not possible for calculating md5 of huge files.

@fanatid had created the md5.js module based on stream.
There is also a branch named feature/update-hashes.

It's possible to update the npm version based on this branch?

I'm also willing to help during the update.

Best,
Xiaoning

@XiaoningLiu XiaoningLiu changed the title npm version of create-hash still use current npm version 1.1.2 of package create-hash does not support stream calcualtion Oct 18, 2016
@XiaoningLiu XiaoningLiu changed the title current npm version 1.1.2 of package create-hash does not support stream calcualtion current npm version 1.1.2 of package create-hash does not support md5 stream calcualtion Oct 18, 2016
@calvinmetcalf
Copy link
Contributor

I'm on vacation but can take a look next week

On Tue, Oct 18, 2016, 12:58 PM XiaoningLiu [email protected] wrote:

Hi,

For package create-hash, current npm version 1.1.2 doesn't support md5
calculation based on stream.

We need buffer all the data in memory and then calculate the md5.
It's not possible for calculating md5 of huge files.

@fanatid https://github.com/fanatid had created the md5.js module based
on stream.
There is also a branch named feature/update-hashes.

It's possible to update the npm version based on this branch?

I'm also willing to help during the update.

Best,
Xiaoning


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#15, or mute the
thread
https://github.com/notifications/unsubscribe-auth/ABE4n75ChhtRK5EeEpBqPFhD4Zl81ELfks5q1Jg3gaJpZM4KZmG3
.

@XiaoningLiu
Copy link
Author

Great thanks!

@dcousens
Copy link
Member

Closing in favour of #19, related to #11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants