Browser window zoom set to 90% hides preferences save button

[apiraino]

UPDATE: Setting Firefox zoom level to 90% hides preferences save button :-)

Screenshot

---

OLD issue description: invalid.

After updating to 3.10.1 my settings are not saved anymore.

How to reproduce:

• Go to the browserpass extension configuration
• Set a custom gpg binary or any other setting
• Go back to the list of extensions
• Open again browserpass extension configuration
• bug: the custom setting is gone

Tested on FF 138.0b2 on Linux

As a result, I had to backpedal to version 3.9.0.

Given the big changes on #366 I suppose cc @patgmiller

Thanks

[maximbaz]

This is a silly question, but are you pressing "save" button in the bottom of the dialog? cc @haji-ali who commented on the same in a chrome-related issue #293

I'm asking because I can't reproduce this on Linux on FF...

[haji-ali]

@maximbaz, I am the one being silly. I actually didn't press Save, I remember looking for the button but somehow missed it multilple times, so I thought it was automatically saved on change. I can suggest aligning the buttons to the right which might be more traditional (fields aligned to side, actions to another). But otherwise I apologize for the noise.

[apiraino]

Well, this is embarassing.

I keep Firefox zoom default to 90% and forgot Browerpass has a "Save" button (last time I touched its prefs was years ago). I even tried switching theme from dark to light thinking that some CSS could make it invisible. Thanks @haji-ali for the hint: the button is actually not visible.

Details

[maximbaz]

Whoa, you are totally right about it disappearing at 90% zoom!

I agree that we should overall revisit the options screen, maybe even move those buttons on top, or auto save on change - PRs are very welcome, if anyone wants to look into this!

[patgmiller]

@maximbaz a simple solution to this would be to allow the options window overflow to scroll.

browserpass-options-overflow-scroll.webm